Teemu Taskula

Results 61 comments of Teemu Taskula

@nickbyte can you provide a repro of this issue in [CodeSandbox](http://react.new/)? Or did you figure it out? Your problem might be related to you changing the container height which will...

Thanks for reporting this πŸ™πŸ» This should be fixed in version [1.6.1](https://github.com/Temzasse/react-modal-sheet/releases/tag/v1.6.1) πŸ™‚

I just released version [1.6.2](https://github.com/Temzasse/react-modal-sheet/releases/tag/v1.6.2) that should improve the body scroll locking behaviour so that the background will not scroll when the sheet is opened. For the content scrolling/dragging issue...

Hi @navnisπŸ‘‹ This doesn't seem to be happening in the [example app](https://temzasse.github.io/react-modal-sheet/#/slack-message) (at least on my iPhone) so it's a bit difficult to tell what is happening on your end....

I have quite limited amount of time to work on this lib at the moment so it would be amazing if someone could help me out by figuring out the...

@shivamragnar unfortunately I don't have the bandwidth to investigate issues like this which are not easily reproducible 😞 I could not reproduce this when I initially tried to debug it...

@atlasbc good suggestion about restricting the minimum value for y to be 0 πŸ‘πŸ» I'll investigate how this can be done with Framer Motion.

Restricting the `y` value didn't help. It seems that this is a "feature" in iOS Safari and not really a bug in the library: https://stackoverflow.com/questions/56351216/ios-safari-unwanted-scroll-when-keyboard-is-opened-and-body-scroll-is-disabled

Using a better body scroll locking implementation from React Aria ([usePreventScroll](https://react-spectrum.adobe.com/react-aria/usePreventScroll.html)) seems to mitigate this issue. I also added the `y` value restriction just to be safe. Hopefully this is...

Sorry for taking so long to respond to this πŸ˜… I took a look at the PR and it seems like a good change (just need to resolve some prop...