MaterialDesign
MaterialDesign copied to clipboard
Templarian
table-row-plus-next
Before submitting a new icon request, please confirm the following:
- [X] I have searched all issues to make sure there isn't a request for this icon.
- [X] I have searched the current library to make sure the icon doesn't already exist.
- [X] I understand that brand icons are no longer being added and I can use SimpleIcons for my brand icon needs.
- [X] I only intend to request a single icon (or a few near-identical ones) in this issue.
What would you use this icon for?
insert a row next to the current one
Give us an example of what this icon might look like.
Combine icons table-row-plus-after and table-row-plus-before. The plus should appear in the middle of the rows
Could only imagine it to be like that, but IMO the table context goes missing with only half a row above and below...
table-row-plus-between.zip
Hi Hans,
Thanks for attempting this. That's exactly the icon I ended up using (sorry I should have tried doing a pull request to the repo as well). I hear you Re: table context going missing. In our case, we were using table-row-plus-after, table-row-plus-before, and 'insert-next' actions close to each other - so the context of the table was still apparent to the user.
If used in isolation however, I totally agree with you...
Arnaud
On Wed, Sep 21, 2022 at 11:48 PM Hans Böhm @.***> wrote:
Could only imagine it to be like that, but IMO the table context goes missing with only half a row above and below... [image: grafik] https://user-images.githubusercontent.com/7279415/191521147-101f14e2-0352-4cd1-8878-837f1e6e4028.png table-row-plus-between.zip https://github.com/Templarian/MaterialDesign/files/9617170/table-row-plus-between.zip
— Reply to this email directly, view it on GitHub https://github.com/Templarian/MaterialDesign/issues/6783#issuecomment-1253739704, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMVSZAPA3UN6K4HUIXMFWLV7MG4FANCNFSM6AAAAAAQPUE3GY . You are receiving this because you authored the thread.Message ID: @.***>
This looks like a table split. Isn't a traditional way to have a row/column that is visually offset to from the neighbours? Such an icon could easily have a plus modifier added for extra clarity.
As written above, I agree that the meaning of the icon is not clear without further context. IMO a plus modifier is not suitable here, since the intention was an addition to table-row-plus-after and table-row-plus-before.
However, thinking about this again, I'm not sure if this addition is even needed as I can't imagine a scenario where you need to insert a row between two (selected) rows rather than either before or after one of these rows...
Hi Hans,
Agreed: The intention was to portray insert before or after the current row. Funny, I used exactly the same icon as the one you drafted. That suited our purposes. However, I cannot think of an icon generic enough to portray insert before/after current row. At least without also changing table-row-plus-after and table-row-plus-before.
I might close this issue...
On Wed, Oct 5, 2022 at 4:10 PM Hans Böhm @.***> wrote:
As written above, I agree that the meaning of the icon is not clear without further context. IMO a plus modifier is not suitable here, since the intention was an addition to table-row-plus-after https://materialdesignicons.com/icon/table-row-plus-after and table-row-plus-before https://materialdesignicons.com/icon/table-row-plus-before. However, thinking about this again, I'm not sure if this addition is really needed as I can't imagine a scenario where you need to insert a row between two (selected) rows rather than either before or after one of these rows...
— Reply to this email directly, view it on GitHub https://github.com/Templarian/MaterialDesign/issues/6783#issuecomment-1267986330, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMVSZDRCSGYEY7U6HIWDR3WBULVHANCNFSM6AAAAAAQPUE3GY . You are receiving this because you authored the thread.Message ID: @.***>