Tim Peierls
Tim Peierls
The associated PR is a lot to take on faith, and it's very hard to test. Is anyone reporting problems due to the current implementation?
Simply having tests to cover lines of code doesn't give me confidence in the correctness of the code. The risk involved in replacing this machinery without feedback from experts could...
I am not a maintainer of this project, so I can't "show the code to the devs" beyond making comments here that interested parties might pick up on. How about...
Some aspects of Failsafe policy behavior can already be computed/enforced on the fly. Some examples: - [computed retry delay](https://failsafe.dev/javadoc/core/dev/failsafe/DelayablePolicyBuilder.html#withDelayFn-dev.failsafe.function.ContextualSupplier-) - [fallback value](https://failsafe.dev/javadoc/core/dev/failsafe/Fallback.html#builder-dev.failsafe.function.CheckedFunction-) - [max retries](https://failsafe.dev/javadoc/core/dev/failsafe/ExecutionContext.html#getAttemptCount--) - [timeouts](https://failsafe.dev/execution-cancellation/) More substantial changes...
Something like the [Clock abstraction](https://docs.oracle.com/javase/8/docs/api/java/time/Clock.html) might be useful, but it would mean some refactoring, because I don't think that it works at nanosecond granularity. (Mind you, I don't think one...
> 1. AtomicBoolean fields are final OK > 2. lambda expression instead of code block Aren't those braces ignored, anyway? It's just a single expression. (The indenting of the modified...
Not up to me.
You can't use both `withDelay` and `withBackoff` in the same `RetryPolicy`, since they use the same configuration fields internally. But you can use a backoff delay in conjunction with a...
`ResourceException` implements `Serializable` only because it extends `RuntimeException`, and it provides a `serialVersionUID` to avoid a warning, but the standard advice for years has been to use something other than...
Nothing wrong with it, but I worry that this will encourage people to rely on the default serialization of ResourceException in other contexts. What if someone else's notion of what...