AdapterJS icon indicating copy to clipboard operation
AdapterJS copied to clipboard

Published 20 hours ago • verified publisher icon Temasys

JSON.stringify issue

Open jauhenk opened this issue 9 years ago • 4 comments

Hey guys, When I path to JSON.stringify any object contains plugin's object JS crashed with Stack Overflow exaction. Could you please pay attention for this? Thanks!

jauhenk avatar May 26 '15 16:05 jauhenk

Hi,

This is a known issue that was reported to us a while ago. See https://groups.google.com/forum/#!searchin/temasys-discuss-webrtcplugin/json/temasys-discuss-webrtcplugin/4pfB16ViObY/vo_eW109nTIJ I suppose that when you say JS crashed you mean threw an exception or an error.

We did have an idea of how to bypass the issue but never got to the implementation (See the other thread).

Best regards, J-O

johache avatar May 28 '15 02:05 johache

+1 please implement support for JSON.stringify. Otherwise we have to hack around it in our WebRTC helper library.

It'd be awesome if the Temasys plugin was 100% a drop-in replacement.

feross avatar Jun 01 '15 17:06 feross

We'll try if we can define a prototype for the plugin object and if JSON.stringify will pick it up. It's nothing we can do in AdapterJS sadly and it needs to squeeze in our crazy busy plugin list of priorities. For now I recommend reading out the properties you need one-by-one instead of stringify. That'll work in any case and is barely a hack, despite not beautiful code.

serrynaimo avatar Jun 02 '15 02:06 serrynaimo

@serrynaimo Some news about this issue? Sometimes use one-by-one properties is so dirty. +1 JSON.stringify implement

oscarvadillog avatar May 31 '16 19:05 oscarvadillog