AdapterJS icon indicating copy to clipboard operation
AdapterJS copied to clipboard

Plugin init issue

Open z0r1k opened this issue 10 years ago • 10 comments
trafficstars

Even though I register callback for onwebrtcready and once it's called I try to create peer connection I get such kind of error Exception: TypeError: undefined is not a function (evaluating 'o.WebRTCPlugin.plugin.PeerConnection(o.WebRTCPlugin.pageId,a,i,r)'). Browser is Safari 8.

z0r1k avatar May 18 '15 16:05 z0r1k

Sorry for the slow reply on your issues... Looking into it!

serrynaimo avatar Jun 02 '15 02:06 serrynaimo

Any updates on it?

z0r1k avatar Jul 20 '15 08:07 z0r1k

What is o ? is it AdapterJS ? Can you call AdapterJS.WebRTCPlugin.plugin.valid ? If it is false it means the plugin isn't properly loaded.

Can you check that the plugin is properly enabled ? It's in Safari options > Security > manage website settings > TemWebRTCPlugin

johache avatar Jul 21 '15 08:07 johache

all these o,a,i,r are coming from minification process. plugin was properly enabled in safari and was not blocked.

z0r1k avatar Jul 21 '15 08:07 z0r1k

Do you have a live test application for me to reproduce on my side ?

johache avatar Jul 21 '15 08:07 johache

Unfortunately not. And it is also happens eventually and not every time.

z0r1k avatar Jul 21 '15 08:07 z0r1k

If it does not happen every time you probably have a race issue. Are you sure you create the PeerConnection in or after the callback is done ? Can you check AdapterJS.WebRTCPlugin.plugin.valid before and after you creation of RTCPeerConnection ? Can you also tried with a non-minfied version of the adapter. If you minify the adapter yourself you need to make sure that __TemWebRTCReady0 is not minified.

johache avatar Jul 21 '15 08:07 johache

Hi z0r1k, Just wanted to check if you had any improvement on this issue.

johache avatar Jul 30 '15 06:07 johache

I had no chance to follow up on this yet, sorry. I will try to do it soon.

z0r1k avatar Jul 30 '15 12:07 z0r1k

I also came across this problem.

The issue was that some of my JavaScript was deleting the AdapterJS.WebRTCPlugin.plugin object in the DOM.

I made it not do this and it works great now in Safari :thumbsup:

seanmheff avatar Feb 04 '16 16:02 seanmheff