fonnx
fonnx copied to clipboard
Probable error in cosine similarity
https://github.com/Telosnex/fonnx/blob/ac30c6fa2bb7f35fcd389b0c421559414b72064b/lib/extensions/vector.dart#L7
Hello,
Being an author of ml_linalg library, I found an error here.
In fact, 1-*
is already considered in Vector.distanceTo
:
https://github.com/gyrdym/ml_linalg/blob/027ddfab120b1e2d0c4d6b676c31e62615ce2374/lib/src/vector/float32x4_vector.dart#L521
P.S. Your library is awesome!