telepathy-qt icon indicating copy to clipboard operation
telepathy-qt copied to clipboard

Remove own smart pointers

Open Kaffeine opened this issue 5 years ago • 1 comments

Remove own smart pointer classes or rationalize their existance.

  • Tp::WeakPtr
  • Tp::SharedPtr
  • Tp::RefCounted

Kaffeine avatar Apr 09 '20 21:04 Kaffeine

Also causes some compile warnings when compiling with C++17 for example

/usr/include/telepathy-qt5/TelepathyQt/shared-ptr.h: In constructor 'Tp::SharedPtr<T>::SharedPtr(const Tp::WeakPtr<T>&)':
/usr/include/telepathy-qt5/TelepathyQt/shared-ptr.h:112:26: warning: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
  112 |             register int tmp = sc->strongref.fetchAndAddOrdered(0);
      |                          ^~~

z3ntu avatar Oct 17 '23 21:10 z3ntu