SwiftSDK icon indicating copy to clipboard operation
SwiftSDK copied to clipboard

Rename SDK to TelemetryDeck SDK

Open winsmith opened this issue 3 years ago • 5 comments

winsmith avatar Nov 03 '21 10:11 winsmith

Is this still needed Daniel? I assume this means renaming away from "TelemetryClient"?

Sherlouk avatar Feb 22 '23 15:02 Sherlouk

I keep waffling on this. All the other SDKs are called "TelemetryDeckSDK" but the Swift one isn't. But I'm afraid it's gonna break a bunch of apps if they update, and it's also kinda not worth it.

winsmith avatar Feb 22 '23 18:02 winsmith

Would certainly be a breaking change, and so would be best to wait until there are other technical reasons for wanting to release a v2.0.0.

Perhaps worth setting up a milestone to keep track of that release? (though given the current issues and feature requests, this could be a while off and if you're not frantic on getting it sorted could be something to put on the backburner!)

Sherlouk avatar Feb 22 '23 20:02 Sherlouk

I've put it on the internal roadmap (which, come to think of it, I wanted to make public at some point – I'll see to that)

winsmith avatar Feb 27 '23 08:02 winsmith

What you could do is rename this to TelemetryDeckSDK and create a new target TelemetryDeck with the old name which only contains an Exports.swift file doing a @_exported import TelemetryDeckSDK. Then, people using the old name should be able to continue doing import TelemetryDeck, but new users would import the renamed TelemetryDeckSDK module directly. While @_exported is not officially a Swift feature yet, it's used in such core places within the Swift ecosystem that one can assume it will become an official feature at some point. Just an idea, in case you still care.

Jeehut avatar Nov 28 '23 11:11 Jeehut