telemint

telemint copied to clipboard

Few issue here: 1. In **nft-item.fc:get_auction_info** we should check if last_bid is NOT null 2. Minor improvement: get method should start with get, so **get_royalty_params()** instead 3. Get rid **common.fc:pack_init_int_message**...

Mishanok

bminaiev

Comparing prefix consumes same amount of GAS so this patch wont introduce additional costs.

5eraph

1. [2234562](https://github.com/TelegramMessenger/telemint/pull/34/commits/734381cc16cab70fdb4d4a3a3ca8677d3d7f95ab) load_uint(32) is sure enough for subwallet_id? subwallet_id::uint32 -> subwallet_id::uint64 https://t.me/d_code/15131 https://t.me/durov/167 2. https://github.com/TelegramMessenger/telemint/pull/34/commits/cbd5c6dd5576b543d2c0072a06ad774ce9acfb3e Duplicate in readme 3. https://github.com/TelegramMessenger/telemint/pull/34/commits/eddde788b4283aac02646ebd3faa04f216dc7cb0 https://github.com/TelegramMessenger/telemint/pull/34/commits/7aa8c922e8767890cb3f0ca07be45e447bc9e82f Suggestion to use Security Policy 4. https://github.com/TelegramMessenger/telemint/issues/36 5. https://github.com/TelegramMessenger/telemint/pull/34/commits/d0b95e3c37d43fde75ea3069548112eac600aa31...

isopen

In a bunch of places `load_dict` is used for things, which are not dictionaries. [example](https://github.com/TelegramMessenger/telemint/blob/1a6cc8d36ee646a9ea0a265c815ca2d63bb16d53/func/common.fc#L182). It is a matter of style (tvm op codes are the same), but I think...

bminaiev

**Bug fixes** - fixed null cell unpacking in `get_auction_info`. The `last_bid` nullability condition was breaking the method, making one unable to get the auction info **Optimizations** - replaced a number...

arterialist

Add TLb description for generated messages?

3

Maybe also add a TLb description of all messages, which contracts could generate and send to external contracts? For example, at the end of the auction, nft-item [sends](https://github.com/TelegramMessenger/telemint/blob/1a6cc8d36ee646a9ea0a265c815ca2d63bb16d53/func/nft-item.fc#L32) an `ownership_assigned`...

bminaiev

Using ~ operator to overwrite balance value

2

I went through the entire smart contracts code and only found a missing op read check that was reported in pr #5. Therefore, I decided to propose to slightly improve...

thekiba

Fix cell underflow in case of empty msg

1

If someone send message without a comment he will get cell underflow exception

xssnick

Telegram auction

1

mhsaad007