Telegram-iOS icon indicating copy to clipboard operation
Telegram-iOS copied to clipboard

Fix incorrect proxy request address type for IPv6

Open Blankwonder opened this issue 2 years ago • 4 comments

I discovered years ago that both the iOS and Mac versions of Telegram send requests to the proxy server for invalid IP , and I created this issue in the TelegramSwift repo about two years ago but got no response. https://github.com/overtake/TelegramSwift/issues/427

So I decided to look into it myself, and I found that MtProtoKit doesn't handle IPv6 addresses correctly at all, so when the upper-level code tries to connect to an IPv6 address via a proxy, it sends a request to an invalid IPv4 address.

This issue has been bugging me for years. Please merge this PR or fix the issue in some other way as soon as possible, thanks.

Blankwonder avatar Mar 16 '22 09:03 Blankwonder

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 16 '22 21:07 CLAassistant

It has been a year since I submitted this Pull Request. The issue is quite severe, yet it only requires 10 lines of code to fix it. Additionally, two reviewers have already confirmed the code. I must say, your approach towards contributions from the open-source community leaves much to be desired.

Blankwonder avatar Mar 17 '23 16:03 Blankwonder

/cc @laktyushin

database64128 avatar Mar 17 '23 17:03 database64128

@laktyushin when can you merge this?

riobard avatar Apr 06 '24 16:04 riobard