TelegramUI icon indicating copy to clipboard operation
TelegramUI copied to clipboard

Fix DialogContent requires a DialogTitle warning

Open toplenboren opened this issue 6 months ago • 0 comments

This should fix #55

image

RadixUI which is used by Vaul, which is used by this library is quite opinionated when it comes to a11y.

It requires to explicitly set <Dialog.Title> (for this library it is <Drawer.TItle>) and <Dialog.Description>

Here is reference issue in Radix: https://github.com/radix-ui/primitives/issues/2986

--

In this PR I just utilize VisuallyHidden and hack my way thorough this warning. The only thing that seems to be added to final DOM is this:

image

--

Thanks for the lib by the way :-) using it to craft a small pet project, works like charm :-)

toplenboren avatar Aug 21 '24 19:08 toplenboren