mistica-android icon indicating copy to clipboard operation
mistica-android copied to clipboard

Android 13593 unify id button

Open DevPabloGarcia opened this issue 1 year ago • 2 comments

:goal_net: What's the goal?

❗ About 20 files are only import changes ❗

Unify Button element Ids

  • button
  • button_text
  • button_text_loading
  • button_progress
  • button_icon

We found a problem with xml element. We can reach icon and text subelement in order to set the new ids. This way, we changed this element to wrap the compose id.

:construction: How do we do it?

  • Delete Button and ProgressButton element
  • Wrap Compose Button in new XML Button
  • Change all instances of old buttons/progress button to use new Button element

☑️ Checks

  • [x] I updated the documentation, including readmes and wikis. If this is a breaking change, update UPGRADING.md to inform users how to proceed. If no updates are necessary, indicate so.
  • [x] Tested with dark mode.
  • [x] Tested with API 23.

:test_tube: How can I test this?

If it cannot be tested explain why.

  • [ ] 🖼️ Screenshots/Videos
  • [ ] Mistica App QR or download link
  • [ ] Reviewed by Mistica design team
  • [ ] ...

DevPabloGarcia avatar Jul 28 '23 13:07 DevPabloGarcia