Tejas Rajopadhye
Tejas Rajopadhye
Currently, email notifications / UI notifications are send for share submission , approval, revoke, reject For share failure and share unhealthy statuses, notifications are not sent. I like the idea...
Will be resolved as a part of - https://github.com/data-dot-all/dataall/issues/1420#issuecomment-2552403340
@anushka-singh , @noah-paige , I am picking this up and working on adding this feature enhancement. I agree with @anushka-singh, that a share is a shared responsibility of dataset owners...
# Implementations ## Proposed way #### Frontend change Update the ShareView.js file with conditional to show reapply share button #### Backend change 1. The reapply share item mutation is decorated...
Miscellaneous finds - Bug - When reapplying share which is in Revoke_Failed state and Unhealthy then the share is processed and put back into Share_Succeeded instead of revoking the share...
@dlpzx , pushed updated PR. Integration tests are failing and will fix them once the PR is reviewed and in a good shape.
@dlpzx , I have updated the PR and replied to your comments where I thought more discussion is needed. I have updated the tests that I had done while submitting...
Hi @dlpzx , I have updated the PR and fixed unit tests. ✅ . Also , I have tested the code with the test cases ( as described in the...
@petrkalos , @dlpzx , Thanks for approving this PR. I have resolved the merge conflicts which were present.
I like option 2 as well. @petrkalos , would this dialog box show for all kind of approvals ( i.e. Read-Only, Write /Modify ) ?