tejaskumar.com icon indicating copy to clipboard operation
tejaskumar.com copied to clipboard

Published 20 hours ago • verified publisher icon TejasQ

Tejamaican PR

Open dalevross opened this issue 5 years ago • 5 comments

First draft of modifications.

  • I assume the attributions could be properly typed such that only integer indices and string attributions are allowed but I'm not quite there yet.
  • I assume the package-lock.json should generally be committed but that's a vague recollection of something I read setting up my first npm project a few weeks ago.
  • The image could be cleaner and I'm hoping to sharpen my graphic skills in 2020.

dalevross avatar Jan 01 '20 21:01 dalevross

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/tejask/tejaskumarcom/cnrbmwgs0 ✅ Preview: https://tejaskumarcom-git-fork-dalevross-master.tejask.now.sh

vercel[bot] avatar Jan 01 '20 21:01 vercel[bot]

Hi Tejas,

It's been a while and I'm now uncertain of the exact changes still required. At this point, it might be best to just get a new fork and redo the changes but please let me know.

dalevross avatar Feb 28 '20 23:02 dalevross

Deployment failed with the following error:

Configuring `regions` is not necessary for Static Files. Deploying Serverless Functions to multiple regions is restricted to paid plans. Upgrade here: https://zeit.co/account/billing.

vercel[bot] avatar Mar 06 '20 13:03 vercel[bot]

@dalevross can you rebase?

TejasQ avatar Apr 07 '20 05:04 TejasQ

I can rebase. Just need to refresh on it. Haven't had to on a github repo and the experience is a little different from what I remember on bitbucket.

dalevross avatar Apr 16 '20 02:04 dalevross