financial-number icon indicating copy to clipboard operation
financial-number copied to clipboard

Add test for javascript numbers

Open ArtskydJ opened this issue 2 years ago • 1 comments

The docs say that it supports a string... But is seems to support js numbers too. And people are gonna pass in JS numbers unless it's forbidden. So to avoid an accidental behavior-breaking change in the future, I figured I'd add a test.

In semver, since you documented that functions require strings, I suppose it wouldn't require a major version bump if you disallowed js numbers as inputs. In practice, that feels kinda wrong.

Note I ran the tests locally and they passed, including my new test.

ArtskydJ avatar Apr 01 '22 20:04 ArtskydJ

It would be a real drag to have to manually call toString on every number input variable 😅

micahswab avatar Jul 22 '22 17:07 micahswab