deepmerge icon indicating copy to clipboard operation
deepmerge copied to clipboard

[Feature request] Pass parent values to `customMerge()`

Open broofa opened this issue 1 year ago • 0 comments

Problem: We'd like to require certain merge paths to always be defined.

For example: If attempting to merge objects a and b, and b.properties is defined, we'd like to throw if `a.properties is not defined.

Current solution: Per this comment, this is accomplished with a customMerge function that looks something like this:

// merge options
customMerge(key) {
  if (key === 'properties') {
    return function (a, b) {
      if (!a) throw Error('properties is not defined');
    }
  }
}

This is awkward. It's just weird that the test for property name and value(s) is split across two different functions.

Proposed solution: Extend the customMerge() method signature to take key, object_a, object_b. This would allow the code above to be simplified:

// merge options
customMerge(key, a, b) {
  if (key === 'properties' && !a) {
    throw Error('properties is not defined');
  }
}

broofa avatar Jan 10 '24 20:01 broofa