deepmerge d.ts type definition error

d.ts type definition error

Open eczn opened this issue 5 years ago • 7 comments

⬆️ the type of t4.a should be a number type, not never.

Nov 18 '19 11:11 eczn

What would be the correct way to fix the type definition? https://github.com/TehShrike/deepmerge/blob/master/index.d.ts#L1-L2

Nov 18 '19 16:11 TehShrike

What would be the correct way to fix the type definition? https://github.com/TehShrike/deepmerge/blob/master/index.d.ts#L1-L2

https://github.com/TehShrike/deepmerge/pull/181 here

Nov 19 '19 08:11 eczn

@TehShrike any plans to merge the PR?

Feb 03 '20 15:02 hakimio

Sorry for not looking in for a while – any other TS folks want to give #198 a review? @teppeis @RebeccaStevens @s-edlund

Oct 17 '20 19:10 TehShrike

I can probably give it a review a bit later today

Oct 17 '20 21:10 RebeccaStevens

Sorry I took a bit longer to do this than I said I would but I just reviewed it. It's good but I found some issue with it; I've commented them there.

Oct 19 '20 22:10 RebeccaStevens