New ALL Upfront RI instances not appearing in Ice

[solidspark]

we have a new group of All Upfront instances not being accounted for in the amortized costs in ice. I added ALL, PARTIAL, NO to the enum instead of using Netflix's patch from December and removed

ice.reservationUtilization=MEDIUM

from ice.properties

as I felt that it was not adding the proper instance pricing for ALL, PARTIAL, NO.

The processor now picks up instance pricing for the new class of instances, but, operation types in the Reservation dashboard are not what we expect:

You'd think we'd be able to see the new Upfront Instances in this list, right?

Comments appreciated.

[vfilanovsky]

This commit 0aa7d7bba52cb49df94e082ca957310f130e6461 should address the problem. Have you tried it?

[nyetsche]

I'm unable to start ice as a .war, because it gets a NullPointerException during the reservation phase:

2015-02-26 12:36:28,133 [localhost-startStop-1] INFO  basic.BasicReservationService  - Setting RI price for sa-east-1 HEAVY t1.micro.sqlserverweb 938.0 0.0
2015-02-26 12:36:28,846 [localhost-startStop-1] ERROR basic.BasicReservationService  - failed to poll reservation prices
java.lang.NullPointerException
        at com.netflix.ice.basic.BasicReservationService.pollAPI(BasicReservationService.java:174)
[...]

But runApp does work. Any idea?

[vfilanovsky]

should be fixed by #154

[nyetsche]

Thanks, I'll check that out in a second. To my previous comment, it turns out that from runApp I had commented out the reservation init code. https://github.com/nyetsche/ice/commit/7f679c18c0673a1e98c01b75dbccf3335cebfbbb