pytest-sugar icon indicating copy to clipboard operation
pytest-sugar copied to clipboard

Proper fix for double colon issue

Open mbachry opened this issue 5 years ago • 4 comments

Test case names in verbose output are no longer correct node ids, so can't be copied to clipboard and passed as pytest command argument. This pull request will keep #153 fixed and bring back correct test case names.

mbachry avatar Mar 18 '19 22:03 mbachry

Thanks for working on this!

Unfortunately CI is broken since a while already. IIRC https://github.com/Frozenball/pytest-sugar/pull/156 should fix it.

blueyed avatar Mar 19 '19 00:03 blueyed

@mbachry CI is fixed, so this can be rebased.

blueyed avatar Jun 09 '19 10:06 blueyed

Codecov Report

Merging #172 into master will increase coverage by 0.23%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #172      +/-   ##
=========================================
+ Coverage   87.47%   87.7%   +0.23%     
=========================================
  Files           2       2              
  Lines         479     488       +9     
  Branches       85      85              
=========================================
+ Hits          419     428       +9     
  Misses         35      35              
  Partials       25      25
Impacted Files Coverage Δ
test_sugar.py 99.32% <100%> (+0.05%) :arrow_up:
pytest_sugar.py 82.59% <100%> (-0.16%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 381cd0e...86f1c22. Read the comment docs.

codecov-io avatar Jun 10 '19 22:06 codecov-io

Hi, could this change be landed?

albertodonato avatar Nov 28 '19 14:11 albertodonato

Hey 👋

Thank you for your PR! I am going through the old PRs in this repository and closing them since a long time has passed since the opening and they may not be that relevant anymore. If you still wish to continue with this pull request, let me know and we can re-open it.

Teemu

Teemu avatar Nov 08 '22 15:11 Teemu