DnsServer icon indicating copy to clipboard operation
DnsServer copied to clipboard

Fixing MISP Connector

Open zbalkan opened this issue 1 month ago • 4 comments

Current version accidentally sends empty string as EDE message and TXT response. Basically, blocks silently. It is mentioned here: https://github.com/TechnitiumSoftware/DnsServer/pull/1403#issuecomment-3615644655

I also added a TTL parameter like Advanced Blocker App.

zbalkan avatar Dec 05 '25 14:12 zbalkan

Thanks for the PR. The Blocking Answer TTL value of 1hr is too long for default value. A short value like 30 sec is good. This is so that if the domain is unblocked by the admin for any reason, the long TTL will have issues since it will get cached with clients. Let the admin/user decide if they want longer TTL value instead of having it as default.

ShreyasZare avatar Dec 06 '25 07:12 ShreyasZare

Thank you. Copilot have some valid points in minor things as well. I'll fix it and push today. It was 60 seconds by default. I made it longer for performance. But I didn't think about whitelisting. This is a scenario I didn't test.

zbalkan avatar Dec 06 '25 07:12 zbalkan

I guess it is better this time.

zbalkan avatar Dec 06 '25 15:12 zbalkan

Looks good.

ShreyasZare avatar Dec 07 '25 09:12 ShreyasZare