LauncherV3 icon indicating copy to clipboard operation
LauncherV3 copied to clipboard

Add more memory options in dialog box

Open kalemiller opened this issue 2 years ago • 7 comments

By popular request (and by that I mean the request of one of my friends), at least one modpack has the ability to demand 16 GB of memory very easily. Adding more options should allow users to use more complex modpacks.

kalemiller avatar Dec 14 '22 20:12 kalemiller

I don't think this is necessary. Which modpacks are using this much RAM?

Pyker avatar Dec 15 '22 21:12 Pyker

https://www.technicpack.net/modpack/ericks-insane-adventure-pack.1186950

The pack doesn't run very well with only 16 GB of memory. The issue as described to me was that at 16 GB it wouldn't handle having "enough" of the world loaded or other dimensions i.e. nether+overworld or something.

I actually watched them share screens, and especially while loading chunks (which have already been generated), memory usage can spike above 18 GB on their world.

kalemiller avatar Dec 17 '22 02:12 kalemiller

If you're looking at the memory usage of the javaw.exe process in Task Manager or something else, just keep in mind that the JVM itself has some overhead.

Pyker avatar Dec 17 '22 15:12 Pyker

The modpack itself recommends 8 to 10 GB of RAM.

Pyker avatar Dec 17 '22 15:12 Pyker

I was looking at their debug menu in the MC client, which reports differently than task manager.

I have no clue about whether the performance issues are common, or any other modpacks that might have them, because I don't actually play modded MC very much. It might not be necessary, but is it harmful to have the extra options?

kalemiller avatar Dec 17 '22 17:12 kalemiller

Keep in mind that Minecraft will take more RAM the more RAM you throw at it. It doesn't, however, mean that it will perform better. Give it too much RAM and you'll start running into the garbage collection taking too long because it can afford to run infrequently since it has lots of memory to play with, but it will also take too long and create noticeable stutters because it's cleaning up too much at once.

Pyker avatar Dec 17 '22 17:12 Pyker

I'll recommend to them to try playing around with the amount of dedicated memory and see how it works out.

kalemiller avatar Dec 17 '22 18:12 kalemiller

I don't see any reason why this shouldn't be merged. Thank you for the PR!

Pyker avatar May 17 '24 19:05 Pyker