Canonical paths should be used when checking if two Paths or Files point to the same place

[Brycey92]

I was looking through the source for the launcher and found that when File::equals(File) is called, it just does a comparison on the Paths from the Files which is implemented as file1.getPath().compareToIgnoreCase(file2.getPath()). Anywhere else in the launcher code that compares Paths without first converting to canonical is subject to the issue as well.

For example, comparing /foo/bar/ and /foo/../foo/bar/ would currently give a false-negative when checked for equality in the above two styles, potentially resulting in data loss such as here: https://github.com/TechnicPack/LauncherV3/blob/master/src/main/java/net/technicpack/autoupdate/tasks/MoveLauncherPackage.java#L63

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Brycey92]

Unstale, please!

[github-actions[bot]]

This issue is stale because it has been open for 90 days with no activity.