Brad Overton

Results 158 comments of Brad Overton

Ah ok. I might have misunderstood the issue, thought it was a bug report rather than a feature request, got confused with the mention of the or helper. Sorry!

I wouldn't be against the addition of a new helper for this. Nullish coalescing is pretty common JavaScript logic these days!

Thankyou for the link, the fork is _awesome_

Have also run into this, with components defined within the app errornously getting `this` added `{{this.debug/save-translations}}` `{{this.side-nav/reading/teacher-toolkit}}` `{{this.side-nav/reading/assignments/re}}` `{{this.side-nav/reading/assignments/rex}}` `{{this.side-nav/maths/teacher-toolkit}}` `{{this.side-nav/maths/assignments}}` Interestingly, plenty of other side-nav components didn't get incorrectly...

I installed from this branch, then ran it and got this error; ```bash npx ember-no-implicit-this-codemod http://localhost:4200 . Cannot find module 'find-package-json' Require stack: - /home/user/my-app/node_modules/ember-no-implicit-this-codemod/bin/cli.js ``` Had to add `find-package-json`...

I like this. Seems simple enough, there's already precedent from other modifiers. Isn't really anything new to learn. Could even add a fixable template lint rule to remove unneeded import...

Thanks for the response Chris (I just watched some of your Glint videos with Dan Freeman very informative thankyou!) It has been some time since I opened this issue and...

Would love this as well. I would like to place a SHA here, but don't want to burden future maintainers of my repo with having to figure out how to...

We'll need eslint v9 support too. Currently I get this error `TypeError: context.getAncestors is not a function` from this line https://github.com/ember-cli/eslint-plugin-ember/blob/7e6bca993226891be07ad367f066323573b672aa/lib/rules/require-return-from-computed.js#L69-L70 `context.getAncestors()` is replaced in v9 https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/#context.getancestors() That's just the...

Can do, wasn't sure. Will jump on that first thing tomorrow