terraform-aws-serverless-static-wordpress icon indicating copy to clipboard operation
terraform-aws-serverless-static-wordpress copied to clipboard

Published 20 hours ago • verified publisher icon TechToSpeech

Release 0.2.0

Open petewilcock opened this issue 2 years ago • 3 comments

Resolves #54 Resolves #48 Resolves #24 Resolves #57 Resolves #50

petewilcock avatar Apr 05 '22 19:04 petewilcock

This also resolves https://github.com/TechToSpeech/terraform-aws-serverless-static-wordpress/issues/50

One question, are you able now to run the workflows against this PR? Curious to see if my PRs broke any of the inspections.

nvnivs avatar Apr 29 '22 11:04 nvnivs

are you able now to run the workflows against this PR? Curious to see if my PRs broke any of the inspections.

Not on the fork. I tried upgrading the tests but it still seems to have the same issue with refspec. I'd need more time to dig into it. Once your PRs get merged to 0.2.0 the tests are run again, and the pre-commit config will make an auto-commit (as you can see here) to fix things like regeneration of terraform-docs. The only other failing test is yamllint complaining about the linelength of the buildspec of codebuild. I've actually got a comment which should ignore that specific test, but it doesn't seem to be honouring it for some reason.

If you install pre-commit yourself, the tests will also run locally before it allows you to complete a commit. Failing tests will auto-fix in some cases, and then you can commit again.

@z0c I'll solve the problem by adding you as a contributor, then you can branch directly on this repo.

petewilcock avatar Apr 29 '22 11:04 petewilcock

Thanks @petewilcock . Actions can be a pain with forks, sometimes a workaround for this kind of issues is to run on the pull_request_target, but that is full of security implications as well...

Next change i will branch in this repo :+1:

nvnivs avatar Apr 29 '22 12:04 nvnivs