RebornCore icon indicating copy to clipboard operation
RebornCore copied to clipboard

[1.16.1] Recipe condition "tag" broken

Open Sturmlilie opened this issue 5 years ago • 4 comments

The "tags" condition cannot be relied upon anymore. This expression in the testing lambda:

ItemTags.getContainer().getEntries()

always returns an empty map. I tried experimenting with a bit:

Set<Identifier> entries = ItemTags.method_29214(BlockTags.getContainer());

which gives me all vanilla-registered item tags at least, but no modded ones. This breaks eg. Blockus compatibility.

Sturmlilie avatar Aug 05 '20 13:08 Sturmlilie

blockus_marble_tempfix.zip

Above is a datapack that temporarily fixes the compatibility (marble grinding) with blockus. Note that earlier report of problems with not being able to craft crude storage units from barrels is very likely also caused by this bug, as the recipes for blockus barrels -> storage unit aren't being loaded either.

Sturmlilie avatar Aug 05 '20 13:08 Sturmlilie

make sure you are testing in production, there is a bug with tags in development mode where any tag file used will overwrite any other one (even with replace:false) meaning adding things to vanilla tags will replace those tags in dev only

Linguardium avatar Aug 07 '20 04:08 Linguardium

How is development mode defined? I mostly test my stuff by compiling to jar and launching the game from MultiMC

Sturmlilie avatar Aug 07 '20 04:08 Sturmlilie

running from intellij for example. or from gradlew runclient.

running from multimc should work fine

Linguardium avatar Aug 07 '20 15:08 Linguardium