package.json-validator icon indicating copy to clipboard operation
package.json-validator copied to clipboard

Support scoped modules.

Open hemanth opened this issue 9 years ago • 14 comments

^

hemanth avatar Oct 06 '15 19:10 hemanth

+1 on this one

bahmutov avatar Dec 03 '15 17:12 bahmutov

/me paws @gorillamania

hemanth avatar Dec 03 '15 17:12 hemanth

I switched to using @hemanth fork in my https://github.com/bahmutov/grunt-nice-package for now

bahmutov avatar Dec 03 '15 17:12 bahmutov

ping @gorillamania would really appreciate getting this merged. I'd be happy to step up as a maintainer if you no longer have time to devote to this project :)

LinusU avatar Sep 22 '16 21:09 LinusU

Yes please! Note this has conflicts that prevent it from being merged. What is your npm username?I'll add you as a maintainer

TechNickAI avatar Sep 23 '16 22:09 TechNickAI

Glad to hear! I'm linusu on npm :)

LinusU avatar Sep 24 '16 09:09 LinusU

@LinusU I've added you as a collaborator on this repo and on NPM. Really appreciate the help!

TechNickAI avatar Sep 27 '16 01:09 TechNickAI

Meow.

hemanth avatar Sep 27 '16 04:09 hemanth

@hemanth I don't have permissions to push the suggestion (or merge conflict resolutions) to your branch. Would you be up for either doing that yourself or giving me permission to?

I know it's been a long time, but I'd love to get this in 😄

JoshuaKGoldberg avatar Mar 28 '24 11:03 JoshuaKGoldberg

@JoshuaKGoldberg I guess @bahmutov has a better fix :)

hemanth avatar Mar 28 '24 15:03 hemanth

Sorry, I don't follow - what's the better fix?

JoshuaKGoldberg avatar Mar 28 '24 16:03 JoshuaKGoldberg

https://github.com/TechNickAI/package.json-validator/pull/48#issuecomment-161726665

Looks like my fork is deleted, so ^ :|

hemanth avatar Mar 28 '24 18:03 hemanth

Ah, gotcha.

For context: I want to accept these changes and give you credit as the author. Do you want to re-fork and send a new PR?

If not / you don't have time, no worries, I can always make them myself and list you as a co-author. But I'd feel bad doing that without giving you the opportunity to be the primary author. 🙂

JoshuaKGoldberg avatar Mar 28 '24 18:03 JoshuaKGoldberg

@JoshuaKGoldberg That's ok, FOSS FTW! ❤️

hemanth avatar Mar 28 '24 20:03 hemanth