FrameworkBenchmarks icon indicating copy to clipboard operation
FrameworkBenchmarks copied to clipboard

Upgrade http4k to v6, JDK and Gradle

Open daviddenton opened this issue 9 months ago • 5 comments

daviddenton avatar Mar 12 '25 22:03 daviddenton

Hey @daviddenton,

Unrelated to this PR, but it seems http4k has more than 10 test mutations, which is no longer allowed:

The number of test mutations will be limited to 10. We do not mind if you open up pull requests between runs to try out various mutations for your framework so long as the total number at any given time does not exceed 10.

https://github.com/TechEmpower/FrameworkBenchmarks/issues/8420

p8 avatar Mar 14 '25 11:03 p8

Hey @daviddenton,

Unrelated to this PR, but it seems http4k has more than 10 test mutations, which is no longer allowed:

The number of test mutations will be limited to 10. We do not mind if you open up pull requests between runs to try out various mutations for your framework so long as the total number at any given time does not exceed 10.

#8420

OK - we'll look at removing some soon. Thanks for pointing it out. 🙃

daviddenton avatar Mar 14 '25 11:03 daviddenton

Hey @daviddenton,

Unrelated to this PR, but it seems http4k has more than 10 test mutations, which is no longer allowed:

The number of test mutations will be limited to 10. We do not mind if you open up pull requests between runs to try out various mutations for your framework so long as the total number at any given time does not exceed 10.

#8420

@p8 As promised https://github.com/TechEmpower/FrameworkBenchmarks/pull/9676 🙃

daviddenton avatar Mar 15 '25 13:03 daviddenton

Well, I confirmed that http4k-helidon-jdbc works on main, but is indeed breaking after this PR's changes.

msmith-techempower avatar Mar 17 '25 20:03 msmith-techempower

yep - I'm not sure what's going on with this. I'll look at it soon. Feel free to close the PR off until I get a chance to look at it 🙃

daviddenton avatar Mar 17 '25 21:03 daviddenton

Closing PR in grooming - feel free to reopen if you want to continue working on it.

msmith-techempower avatar Nov 11 '25 17:11 msmith-techempower