FrameworkBenchmarks icon indicating copy to clipboard operation
FrameworkBenchmarks copied to clipboard

Unintended Deletion of Other Containers During Benchmarking: Normal or Error ?

Open jeffersonjpr opened this issue 2 years ago • 2 comments

After running the benchmarks, I noticed that other containers had been deleted. I'm not sure if this is normal or if I did something wrong, as I couldn't find anything in the readme or wiki that suggested this would happen to other containers as well.

OS

image

Steps to reproduce behavior

I executed the quick start Quick Start Guide

jeffersonjpr avatar Apr 04 '23 20:04 jeffersonjpr

That shouldn't be the case. Were you able to reproduce this a few times? The status of your container was exited already?

The code in the toolset seems to be only stopping containers with techempower in the image tags:

    @staticmethod
    def __stop_all(docker_client):
        for container in docker_client.containers.list():
            if len(container.image.tags) > 0 \
                    and 'techempower' in container.image.tags[0] \
                    and 'tfb:latest' not in container.image.tags[0]:
                DockerHelper.__stop_container(container)

but might be happening elsewhere. I'll try and reproduce this when I can.

NateBrady23 avatar Apr 05 '23 20:04 NateBrady23

It only happened once. I began monitoring the benchmark using docker ps while also keeping an eye on my computer's performance with htop. I did not use any docker commands while the benchmark was running. After the benchmark completed, I ran docker ps -a to check if the cleaning process was successful and confirmed that there were no containers left. However, I noticed that my metabase container was missing.

jeffersonjpr avatar Apr 05 '23 22:04 jeffersonjpr