FrameworkBenchmarks icon indicating copy to clipboard operation
FrameworkBenchmarks copied to clipboard

Ur/Web updates

Open sheganinans opened this issue 3 years ago • 6 comments

Hello! I am interested in getting the Ur/Web benchmark back up and running, I noticed the error at:

https://tfb-status.techempower.com/unzip/results.2022-03-21-18-55-25-452.zip/results/20220316112215/urweb-cache/cached-query/verification.txt

This is just the first step to update the code to conform to the new requirements, Travis may reveal more..

sheganinans avatar Mar 26 '22 08:03 sheganinans

I'm a bit puzzled by the the recent error we're receiving in the test. It says that the query path must be at least 8 character, and now it's over that limit and it's still not having it..

sheganinans avatar Mar 31 '22 03:03 sheganinans

@sheganinans Thanks, that's actually a typo. The cached queries path needs to be at least 15 characters long: like /cached-queries. I've fixed in the toolset and docs.

NateBrady23 avatar Mar 31 '22 21:03 NateBrady23

@nbrady-techempower Ok, thank you, I thought I was going crazy for a second... Ok, I'll update the files when I get home tonight and I'll squash and re-push.

sheganinans avatar Mar 31 '22 21:03 sheganinans

@sheganinans We're starting preview runs for Round 21. Haven't looked at why this isn't passing, do you have any time to take a look? Maybe pulling in the master branch and not doing a force push to trigger a new check

NateBrady23 avatar May 31 '22 15:05 NateBrady23

Yes, so the main issue is that it seems like the MySQL branch is now old and a bit bitrotted... I suppose it might be worthwhile to just disable those tests. If that seems reasonable, I'll do that and submit a new push.

On Tue, May 31, 2022 at 8:40 AM Nate @.***> wrote:

@sheganinans https://github.com/sheganinans We're starting preview runs for Round 21. Haven't looked at why this isn't passing, do you have any time to take a look? Maybe pulling in the master branch and not doing a force push to trigger a new check

— Reply to this email directly, view it on GitHub https://github.com/TechEmpower/FrameworkBenchmarks/pull/7247#issuecomment-1142299808, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQL7G5DSM7PVJALHGY2463VMYXFHANCNFSM5RWLLZKQ . You are receiving this because you were mentioned.Message ID: @.***>

sheganinans avatar Jun 03 '22 21:06 sheganinans

@sheganinans Sure, that works!

NateBrady23 avatar Jun 06 '22 15:06 NateBrady23

@sheganinans Going to close this for now. Re-open whenever you get the chance to work on it. Thanks!

NateBrady23 avatar Nov 27 '22 23:11 NateBrady23