node-auto-launch icon indicating copy to clipboard operation
node-auto-launch copied to clipboard

Unable to make the application run on startup for all users

Open anaszgh opened this issue 8 years ago • 5 comments

Platform: Windows 10 x64 Node v6.11.2 auto-launch v5.0.1

Using electron, and after installation i run a form which user has to enter configuration for the application, there the auto-launch should work, the problem is that the installation wizard (thus the configuration form) runs under a specific user, and the main application (which i need to set the auto launch for) runs under different user.

And because of this the auto launch functionality wont work because the registry change is under HKCU, to resolve this there must be a parameter in the construct whether the auto launch should be for all users or not, and this boolean value will decide whether to make the change in HKCU or HKLM.

anaszgh avatar Oct 03 '17 07:10 anaszgh

Oh nice find. We would be open to adding that. Could you open a pull-request? 😄

adam-lynch avatar Nov 11 '17 17:11 adam-lynch

@adam-lynch Sorry for being late, I'm unable to push my code, can you please help through it?

remote: Permission to Teamwork/node-auto-launch.git denied to anaszgh.
fatal: unable to access 'https://github.com/Teamwork/node-auto-launch.git/': 
The requested URL returned error: 403

anaszgh avatar Nov 27 '17 08:11 anaszgh

@anaszgh no problem. Only maintainers of this project have access/permission to push directly to the repository directly. So what you need to:

  1. Create a fork. This is essentially a copy of the project you own. Here is a GitHub help article on that: https://help.github.com/articles/fork-a-repo/.
  2. Push your code there.
  3. Create a pull-request, i.e. a request to take the code you pushed to your fork and add it to the original project. Here is a GitHub help article on that: https://help.github.com/articles/creating-a-pull-request-from-a-fork/.

Let me know if you've any questions 😄

adam-lynch avatar Dec 02 '17 12:12 adam-lynch

Is the pull-request has been merged in to the master?

itsre avatar Dec 10 '17 07:12 itsre

Not yet, sorry for being late, i'll do it today 😄

anaszgh avatar Dec 10 '17 08:12 anaszgh