material-ui-chip-input icon indicating copy to clipboard operation
material-ui-chip-input copied to clipboard

Published 20 hours ago • verified publisher icon TeamWertarbyte

Removed negative margin on FormHelperText

Open vdh opened this issue 4 years ago • 5 comments

A negative margin is not how the official TextField handles the FormHelperText, so it shouldn't be baked into this style here.

Fixes #266

vdh avatar Apr 03 '20 12:04 vdh

Coverage Status

Coverage remained the same at 84.874% when pulling 0623d054c5ced07c031cf7679d0580605d1d91f7 on vdh:patch-1 into aebb65c5b424e79aa0e94dcb51faff5d34f0ebcf on TeamWertarbyte:master.

coveralls avatar Apr 03 '20 12:04 coveralls

Would be good to get this merged, seeing same issue on my end

delewis13 avatar Oct 15 '20 04:10 delewis13

This creates another problem. The underlining is moved under the helper text: image

dulev avatar Oct 29 '20 15:10 dulev

@dulev I can't debug a screenshot, please provide a reproduction…?

vdh avatar Nov 02 '20 00:11 vdh

From a preliminary investigation (via the Storybook and manually disabling the style in Chrome Developer Tools), it looks like for the standard variant it seems to be problematic, whilst filled or outlined (the variant I was using most) seem unaffected.

The underline for the standard variant seems to be attached to the wrong element, instead of its child element?

vdh avatar Nov 02 '20 00:11 vdh