material-ui-chip-input
material-ui-chip-input copied to clipboard
TeamWertarbyte
Add support for start and end adornments
Initial work was designed for supporting different input variants (IE. outlined and filled inputs). Mostly style changes, however there was some items being overwritten on alternative variants of inputs. Due to those differences, code was changed to make the rendering more uniform across different input styles
Also adds color to the chip renderer by default. Should not be an breaking API change as it includes the same default value and is within an param object.
Allows for some more style overriding for chips, and for start/end adornments
This may also address #241 because I noticed the same issue with what I was working on. YMMV since I wasn't working on that per se
Coverage decreased (-2.2%) to 73.867% when pulling 54c5c61f49bb2288cc126db942ac24134c1fabb6 on me245:master into 49bc0589d57a29f399c2106c69cb7157ae368e0b on TeamWertarbyte:master.
@me245 Thank you very much for your PR! :tada: I'm pretty busy currently but I'll come back to it this weekend.
I added some story book stories and noticed some glaring style issues and needed to fix those. Let me know if there is something else that you want me to take a look at
@me245 Sorry, I've been pretty busy (and also I don't get Slack notifications for new comments anymore. Thank you for the new stories. I'll review this this weekend and probably merge the PR. Thank you very much! :tada:
@viart Yes. As soon as either
- someone who needs this gets this rebased and updates it according to the previous review :100: :sunglasses: :+1:
- I find some time to implement this :sweat:
If you want to give this a shot, I'd really appreciate a succeeding PR! (You can fork the fork :wink:)
Cc @geilecj
Any chance this is getting merged, or I could have a shot fixing it and merging it, if that's ok, I'd need a few pointers due to my newness to OpenSource
