VancedManager icon indicating copy to clipboard operation
VancedManager copied to clipboard

Jetpack Compose Migration

Open X1nto opened this issue 4 years ago • 4 comments
trafficstars

Description

This is a very huge change in the whole Vanced Manager source code. Not only it improves the code readability by 10000000000000000%, but it also allows us to implement new features and bug fixes much faster, as well as add new UI elements without any headaches. The goal of migration is to reduce bugs and crashes caused by a ~~shit~~ bad code in the current source code and increase user satisfaction by a whopping 420.69%. All hail the Android team for making Jetpack Compose. Current source code just gives me depression and Ligma as it's impossible to maintain.

TODO

  • [ ] Add a working downloader
  • [ ] Add a working installer
  • [ ] Finish UI

X1nto avatar May 30 '21 16:05 X1nto

:pogslide:

TacoTheDank avatar Aug 02 '21 14:08 TacoTheDank

:trollface:

sudo-nautilus avatar Aug 05 '21 08:08 sudo-nautilus

Hey @X1nto, I was checking your navigator implementation and it looks good however you're not saving the state using SavableStateHolder which will cause issues with process death.

Here's more info on it: https://developer.android.com/reference/kotlin/androidx/compose/runtime/saveable/SaveableStateHolder

P.S: You can probably close #62 now

Skrilltrax avatar Aug 09 '21 18:08 Skrilltrax

Hey @X1nto, I was checking your navigator implementation and it looks good however you're not saving the state using SavableStateHolder which will cause issues with process death.

Here's more info on it: https://developer.android.com/reference/kotlin/androidx/compose/runtime/saveable/SaveableStateHolder

P.S: You can probably close #62 now

Thanks for the info, I'll definitely implement proper state saving when I get my hands on manager. About #62, I'll probably close it after this gets merged to dev

X1nto avatar Aug 09 '21 18:08 X1nto