utime icon indicating copy to clipboard operation
utime copied to clipboard

Pac3 outfits lag behind with utime installed

Open thegrb93 opened this issue 6 years ago • 11 comments

https://github.com/CapsAdmin/pac3/issues/767

thegrb93 avatar Jul 12 '19 01:07 thegrb93

Thanks, we'll keep this open as a record of the conflict.

Nayruden avatar Jul 12 '19 12:07 Nayruden

Fixed the title. Fyi, the issue seems to be from doing traces within the Panel:Think, perhaps if that was moved to Gamemode;Think, it might be fixed. Idk though

thegrb93 avatar Jul 12 '19 14:07 thegrb93

You also ought to add a bug label.

thegrb93 avatar Jul 12 '19 14:07 thegrb93

We use the bug label to signal a bug in the codebase hosting the issue tracker. Why do you think the trace is the cause of the conflict? UTime has been tested under a variety of conditions for 12 years and has had minimal issues. I'm not trying to get you on the defensive, I want to solve the issue here; best practice does dictate that the UI shouldn't be calling traces, so I'll move it into the slower think instead, but I doubt that's the underlying problem.

Nayruden avatar Jul 12 '19 14:07 Nayruden

It's been reported over the years as being the conflict but I think everyone just ended up uninstalling utime as the solution instead of reporting it.

GM:Think isn't slower, idk why you called it slower, but that is the only thing in utime I could find that had any pertinence to game physics/entity logic.

thegrb93 avatar Jul 12 '19 14:07 thegrb93

You can see they date back to 2016 https://github.com/CapsAdmin/pac3/issues/250 and https://github.com/CapsAdmin/pac3/issues/300

thegrb93 avatar Jul 12 '19 14:07 thegrb93

We called it slower so there wouldn't be performance issues and because users generally don't care about a 0.5-second delay.

Nayruden avatar Jul 12 '19 14:07 Nayruden

Oh I misunderstood, you plan on calling it less but still in the Panel:Think. I thought you were saying GM:Think was slower. You should try moving it to GM:Think. Different hook contexts can lead to different behavior in gmod. Yeah it would be a garrysmod bug, but neither we nor they can/will do anything about it.

thegrb93 avatar Jul 12 '19 15:07 thegrb93

Would be amazing if this could be solved without outright removing utime

samcadams avatar Jul 23 '19 18:07 samcadams

@Fires1 see if this version helps at all https://github.com/thegrb93/utime/tree/patch-1

thegrb93 avatar Jul 23 '19 21:07 thegrb93

@Fires1 any luck with the fix?

thegrb93 avatar Jul 25 '19 16:07 thegrb93