[BUG] Incorrect counting of HANDS

[peter-vasut]

Is there an existing issue for this?

• [X] I have searched the existing issues and none matched.

Operating System

Linux

CPU

No response

GPU

No response

Storage

No response

Game Version

5.0.0-041

Game Mode

dance

Theme

default

Describe the problem

After playing every note and hold in the song, the stats show only 4/5 HANDS. The song has only 4 hands (see attached simfile).

Here is the relevant part of the simfile (I've removed zero lines and beat separators for clarity):

M202
00M0
1000
0010
1000
0020
0030
0303

Notice there are start of two holds, then 3 taps, then one hold that ends immediately, then the original holds end. So in total there are 3 taps + 1 hold that should be counted as hands.

Removing the short hold resolves the issue (making the resulting count 3/3). Replacing it with tap resolves the issue (making the resulting count 4/4). It looks like something weird is going on when there is this short hold.

Describe what should happen

The total number of hands should be 4, so that the stats will show 4/4 hands.

Relevant Log output

simfile (the beginning and end is intentionally blank, only affected part is included for testing)

[JoseVarelaP]

Have made a fix, but I'm going to perform more tests to see how it affects RadarValues on similar looking charts.

https://github.com/TeamRizu/OutFox/assets/23246027/7fe33d4f-ecf8-41ed-9e97-a333daec36e6