TeamRizu
[BUG] Timing completely off on SOME split timing songs
Is there an existing issue for this?
- [X] I have searched the existing issues and none matched.
Operating System
Linux
CPU
AMD Ryzen 5 3550H
GPU
No response
Storage
No response
Game Version
4.12.0
Game Mode
dance
Theme
Tested on both default and XX Starlight(latest).
Describe the problem
Song is from D3NEX Maximum pack (pack is defunct, zipped the simfile and upped it) It doesnt want to recognize the stops and bpm changes correctly on expert(15, the most obvious show that there is something off) and challenge(16) difficulties. Tested the file in 5.1 and it works correctly. Thing is, that immediately tested Ace for Aces (the 1 official konami song with split timing, dl'd from ZiV.com DDR A category) and it works properly.
Describe what should happen
The 1st show that there is something off would be on the challenge chart, there's a stop on the 1st mine/shock arrow line (66th beat, 24.8 seconds in) . Outfox skips it completely.
Relevant Log output
Ok figured it out. the .ssc files of this pack all have
#STOPS:;
#DELAYS:;
#WARPS:;
On the "header" section of the file, lines 25-27. Removing them fixes it, but the pack is 100 songs big so I'm not getting this done file by file. (also, who knows if there are more packs formatted like this) I'm guessing that outfox ignores all split timing if these lines are present, shouldn't it be done reversely? ignore the header lines if split timing is present?
The version that the song is written to (0.81) matches exactly the check we have for detecting PIU charts coming from places like StepF2, which in part make the parser load the chart with different settings. So, to fix this, just change the #VERSION tag to 0.83.
Uhmmm... I would like to jump in as I've played through this very pack as well, came across this simfile (and 10 others with this issue within the same pack) and am NOT liking the "fix" to this issue.
And just to nudge it nicely into the right direction, I'm just asking this one question: Does the "check for detecting PIU charts" also check if the steptype is from PUMP and not any other gamemode? It might actually currently be doing stuff where it shouldn't, like this dance stepchart?
