REPENTOGON
REPENTOGON copied to clipboard
TeamREPENTOGON
[META] Online coop checklist
Existing issues from REP- discovered while working on REP+
- [ ] Isaac.Get/SetDwmWindowAttribute - Set->Get returns weird values
Known issues in REP+
- [ ] Co-op menu must be sufficiently blocked off while REPENTOGON is active (mostly done, need to block invitations, maybe other stuff?)
- [x] Isaac.SetIcon can break if called too many times
- [x] Decoration grids are not spawning naturally (likely related to grid entity spawn patches)
REP+ issues that might get fixed by nicalis
- [ ] https://github.com/epfly6/RepentanceAPIIssueTracker/issues/599
- [x] https://github.com/epfly6/RepentanceAPIIssueTracker/issues/598
Things that could maybe use some more fleshed out tests
Honestly, if you feel like adding some tests for ANYTHING, especially rgon features, go for it. But in particular there were a few things I thought could be worth a look for writing tests, either due to complexity or awkwardness in actually writing tests for it.
- [ ] GenericPrompt
- [ ] Custom Item Pools
- [ ] LootList
- [ ] Ambush (weird to set up a testable state mid-test)
- [ ] EntitiesSaveState / GridEntityDesc (savestate related)
- [ ] ASM patch etc stuff if not covered yet, like ASMCallbacks/ASMXMLItem/CardsExtras
quick q: will repentagon be enabling at least client based mods in online? Like for instance disabling things like registering items or maybe just supporting them outright anyways?
There's no clearcut way of defining a "client based" mod because Isaac was never meant with this structure in mind. It's an all or nothing deal and even just changing animations can cause a desync as some entities have event triggers within animations.
It is far too early to be discussing online mods. We need to get the thing ported first and wait for the dust to settle, features come later.
fair enough. I just miss EID bc my brain is bad at remembering things
According to the changelog, "Mod creators will need to update their mods for compatibility. If you copy Repentance or AB+ mods into this folder, YOU DO SO AT YOUR OWN RISK as things are likely to break." Do you think this indicates actual changes to the API, or is it just a standard disclaimer?
We dont think, WE KNOW and CONFIRMED that the api is just fucked on several places....they probably just used that as an excuse to buy time and have people blame modders for a while.
MenuManager::RenderButtonLayout was inlined, thus we likely need to move MC_MAIN_MENU_RENDER to an ASM patch.
Added a new section at the bottom where we can shove pending mismatches that we are not able to solve immediately so maybe others can in the meantime. First one in there to break the ice is Entity_Player::ReviveFromCollectible (currently matching Grid_Fire::Update)
We dont think, WE KNOW and CONFIRMED that the api is just fucked on several places....they probably just used that as an excuse to buy time and have people blame modders for a while.
Did the new patch to Rep+ fix it?
improved but not completely, there are still issues ranging from functions not working to crashing outright
A new update released, so how much did it break/fix the modding stuff?
A new update released, so how much did it break/fix the modding stuff?
Like this
A new update released, so how much did it break/fix the modding stuff?
Nicalis made a lot of positive changes to the API in the latest update but also mistakenly removed a feature mods were using to tell if they were running on AB+ or Repentance. Without actually checking, I'd guess mods might be more broken now compared to last patch as a result. We've already notified them.
I don't quite understand the discussion here. Does it mean that this mod does not support online connection? If I install this mod, do I need to disable it in the startup options when I want to online co-op? I also search web page, but I don't get answer
I don't quite understand the discussion here. Does it mean that this mod does not support online connection? If I install this mod, do I need to disable it in the startup options when I want to online co-op? I also search web page, but I don't get answer
Repentance+ version of Repentogon will disable access to the online mode (except for Daily Runs)
I don't quite understand the discussion here. Does it mean that this mod does not support online connection? If I install this mod, do I need to disable it in the startup options when I want to online co-op? I also search web page, but I don't get answer
Repentance+ version of Repentogon will disable access to the online mode (except for Daily Runs)
Nothing new here, you cannot play co-op with mods, repentogon is a mod.