TeamREPENTOGON
[Request] Fix the PushRenderTarget log spam
Dear Repentogon Devs,
Could you fix this bug in the game? It is described here, under StartRoomTransition (): https://wofsauge.github.io/IsaacDocs/rep/Game.html
Transcription of the bug description:
Note that if you use RoomTransitionAnim.PIXELATION (2), you must not interrupt the effect (e.g. with another room transition or room change) once it starts playing. Otherwise, after around 11 interuptions, the "log.txt" will start to become spammed with "[ASSERT] - PushRenderTarget: stack overflow!". This is because internally, the game uses a finite buffer to store information about the effect, and if it is interrupted, the buffer will never be cleared.
Game Version: 1.7.9b Repentogon Version: 1.0.4
I'm hesitant to call this a bug so much as one of many things that could go wrong interrupting a non-interruptable rendering state
Just wondering if there could be an "Enable Logging" option in the game options tab to prevent the spam?
While this would silence the error, it would not solve the underlying issue. Due to the way the render system works, interrupting a non interruptible rendering state will keep adding render states to the stack. This will leak memory (which is already scarce in Isaac), eventually leading to a crash.
A proper fix would be to prevent other transitions from playing while this one is active (which would be difficult)
