Piped icon indicating copy to clipboard operation
Piped copied to clipboard

10 second scroll on double tap player

Open IvRRimum opened this issue 4 years ago • 5 comments

This comes at the cost of double tap to fullscreen, i guess we could override the the shaka player logic and make and edge case for mobile devices, like here: https://github.com/google/shaka-player/commit/cf5d893d6ff3dc43da89131570debc30348a1437

IvRRimum avatar Aug 01 '21 21:08 IvRRimum

But then again, double tap to fullscreen is a lot less used than double tap to 10 sec forward/backward, so i guess it works for now

IvRRimum avatar Aug 01 '21 21:08 IvRRimum

I really want to use https://github.com/google/shaka-player/pull/3373 instead.

FireMasterK avatar Aug 02 '21 03:08 FireMasterK

Like integrate this feature using shaka player api? Or do you want to have this feature integrated into the shaka player repo?

IvRRimum avatar Aug 02 '21 09:08 IvRRimum

I'm interested in the PR in shaka-player (linked above), that adds native support for this. I want to avoid additional code here if possible.

FireMasterK avatar Aug 02 '21 10:08 FireMasterK

Ohh, well it depends on them if they want to merge that feature. I will have time next weekend, might be able to do that.

IvRRimum avatar Aug 02 '21 10:08 IvRRimum

https://github.com/shaka-project/shaka-player/pull/5943

Bnyro avatar Jan 14 '24 13:01 Bnyro