Piped icon indicating copy to clipboard operation
Piped copied to clipboard

Do not require multiple domains

Open Atemu opened this issue 1 year ago • 0 comments
trafficstars

Describe the feature

Rather than requiring a separate domain for API and proxy, place these under the primary domain of the service. The reverse proxy should then redirect the requests to the respective services.

pipedapi.domain.name -> piped.domain.name/api/
pipedproxy.domain.name -> piped.domain.name/proxy/

Why would this be useful to add?

Subdomains can be a PITA to manage. I ran into this while adding abstractions for automatic deployment of this service.

Most other services I've seen do it differently; one exposed domain per service.

Concept(s)

No response

Additional context

Piped frontend stores the current API URL as state in local storage. Twice actually (why?). This stored URL is then used to make requests (why??).

This is a poor design because an instance could already choose to change its API domain while front-end users would keep querying the old domain due to their local storage.

This would have to change if all instances were forced to change the path of the API endpoint.

Acknowledgements

  • [X] I have searched the existing issues and this is NOT a duplicate or related to another open issue.
  • [X] I have written a short but informative title.
  • [X] I filled out all of the requested information in this form.

Atemu avatar Jan 11 '24 14:01 Atemu