Piped icon indicating copy to clipboard operation
Piped copied to clipboard

Published 20 hours ago • verified publisher icon TeamPiped

Improve Margins and add Theater Mode

Open maltejur opened this issue 2 years ago • 4 comments

Improve a few margins. I know there is a UI rework coming but this should be just a small quick change. Most notably, add a margin to the left and right of the page if a video is playing.

Before: Screenshot 2022-06-16 at 21-31-52 Piped

After (note that the video has pretty much the same space due to the black bars): Screenshot 2022-06-16 at 21-32-04 Piped

Before: Screenshot 2022-06-16 at 21-32-41 Piped

After: Screenshot 2022-06-16 at 21-32-29 Piped

Let me know what you think. If you want to merge the page margin at the left and right, I could also implement a "theater mode" that reverts it again. If not, I could also exclude the page margin from this MR.

maltejur avatar Jun 16 '22 21:06 maltejur

I could also implement a "theater mode" that reverts it again.

I would love that since I love how currently the full screen's real estate is used.

FireMasterK avatar Jun 17 '22 12:06 FireMasterK

Okay, done. Also got a quick preview here: https://piped-80dr7mank-maltejur.vercel.app/

maltejur avatar Jun 17 '22 16:06 maltejur

@maltejur @FireMasterK what's the blocker here?

kskarthik avatar Jun 25 '22 07:06 kskarthik

Some problems/things I noticed in my testing:

  • When loading the home/other pages, it would initially flicker from the half-screen layout to full screen
  • The logo, feed/login buttons on the top are in the center
  • I don't like this being the default personally, but I could create a poll to see what the community wants.

FireMasterK avatar Jun 25 '22 10:06 FireMasterK