NewPipeExtractor icon indicating copy to clipboard operation
NewPipeExtractor copied to clipboard

[Request] Add twitch.tv support

Open gergesh opened this issue 6 years ago • 17 comments

With the direction that the app and extractor are going in, I think this will be a welcome addition.

For the unaware: Twire is a FOSS Twitch app.

gergesh avatar Mar 25 '18 21:03 gergesh

Yes of course. :D

Help is always welcome, however I'm trying to add twitch support when i work on the extractor documentation

theScrabi avatar Mar 26 '18 06:03 theScrabi

The documentation link is no longer available

moshpirit avatar Dec 28 '21 14:12 moshpirit

https://teamnewpipe.github.io/documentation/

theScrabi avatar Feb 19 '22 10:02 theScrabi

Any news on this over four year old suggestion about adding twitch.tv to New Pipe?

Eiion avatar Jul 20 '22 15:07 Eiion

Indeed! Here is the news: https://github.com/twireapp/Twire/issues/314#issuecomment-1047837454

opusforlife2 avatar Jul 21 '22 16:07 opusforlife2

Yes, but there is the internal GraphQL API which works without login at all for the features the extractor provides and should be the one the extractor should use.

AudricV avatar Jul 21 '22 16:07 AudricV

@AudricV See the "allowed" section and Source no. 2 of OP: https://github.com/twireapp/Twire/pull/238

opusforlife2 avatar Jul 21 '22 16:07 opusforlife2

Indeed! Here is the news: twireapp/Twire#314 (comment)

This thread is about adding twitch.tv support to new pipe. You're just linking to a completely different repository - that's not answering my question.

Eiion avatar Jul 23 '22 15:07 Eiion

That completely different repository contains the answer to your question.

opusforlife2 avatar Jul 25 '22 04:07 opusforlife2

No, it does not. It's a completely different repository that has nothing to do with New Pipe. And especially when Twire is a thing that doesn't answer my question regarding the progress of adding twitch support to New Pipe when that was requested over four years ago already. BTW, it would have taken you less effort to give a proper reply than what you've said so far.

Eiion avatar Jul 25 '22 08:07 Eiion

@AudricV See the "allowed" section and Source no. 2 of OP: https://github.com/twireapp/Twire/pull/238

@opusforlife2 Since we won't be allowing logging in to Twitch, using the internal GraphQL API should pose no problem for us; it's no different from our usage of the internal YouTube API. Twire cares about this probably because they allow login (and it is now required because of Helix version of the Twitch official API), and if Twitch detects an account using the internal API from a third-party client, they may ban that account.

@Eiion We still haven't taken a decision about whether to add the Twitch service into the extractor.

Also note that it seems that this internal API is also used by yt-dlp to download Twitch videos.

AudricV avatar Jul 25 '22 15:07 AudricV

@Eiion We still haven't taken a decision about whether to add the Twitch service into the extractor.

Also note that it seems that this internal API is also used by yt-dlp to download Twitch videos.

Thanks @AudricV, I appreciate the update! (If I understand you right you're advising against the use of Twire?)

Eiion avatar Jul 25 '22 17:07 Eiion

If I understand you right you're advising against the use of Twire?

Not at all, if Twire devs want to use the official API, that's their decision, which is understandable, especially in terms of respect of Twitch TOS (which should be important when using Twitch accounts I think) and API stability.

AudricV avatar Jul 25 '22 17:07 AudricV

Ah! I understand now. That PR description was written months before Twire made using accounts mandatory. The way it's written gave the impression that the usage of the internal API was problematic despite not logging in. As in IP bans or something similar.

Thanks for the clarification, @AudricV. Sorry about the confusion, @Eiion.

opusforlife2 avatar Jul 25 '22 17:07 opusforlife2

If I understand you right you're advising against the use of Twire?

Not at all, if Twire devs want to use the official API, that's their decision, which is understandable, especially in terms of respect of Twitch TOS (which should be important when using Twitch accounts I think) and API stability.

Oh, because "if Twitch detects an account using the internal API from a third-party client, they may ban that account" sure sounded like it. But I assume this was meant about the account utilizing the API i.e. Twire devs (not the average user logging into their Twitch account via Twire).

(And I'd mark this off-topic myself if I could. Sorry, just asking to clarify what was said previously.)

Eiion avatar Jul 26 '22 13:07 Eiion

Are there any updates on this, or is it deferred until the rewrite has been completed?

DominiqueSite avatar Jan 09 '24 22:01 DominiqueSite

Definitely deferred. Adding a new service is a major undertaking, for sure. And one of the very goals of the rewrite is to make this task easier.

opusforlife2 avatar Jan 11 '24 12:01 opusforlife2