TeamNewPipe
[Soundcloud] replace deprecated id with urn
Checklist
- [x] I am aware that this issue is being opened for the NewPipe Extractor, NOT the app, and my feature request will be dismissed otherwise.
- [x] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
- [x] I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
- [x] This issue contains only one feature request.
- [x] I have read and understood the contribution guidelines.
Feature description
The id field in the api is now deprecated and we must now use urn instead. Must be done before 30th June otherwise functionality is not guaranteed.
I'll most likely have this done by 15th June cus I'm already working in this area of the code.
Why do you want this feature?
Self explanatory
Additional information
No response
Update on this: after working on this for a while, it seems that browser soundcloud is not actually using URNs in it's API requests.
Moreover, not every API resource can be queried by a URN, and the ones that can only work if the URL path ends at the resource (i.e. https://api-v2.soundcloud.com/tracks/soundcloud:tracks:123456/).
Getting things related to a resource like https://api-v2.soundcloud.com/tracks/soundcloud:tracks:123456/comments will return 4xx or 5xx, but using the numeric ID works as expected.
Due to this, I don't think it's urgent to fix this anymore, and I am not sure if this change will actually affect the internal Soundcloud API at all, so I am pausing my development on it.
If suddenly Soundcloud breaks in NewPipe cus of this at a later date then I will finish my work on it on my local branch