TeamNewPipe
[YouTube] Fix signature deobfuscation function name extraction
Adds a new regex to find the signature deobfuscation function that works for the new 20830619 player. The regex is taken from https://github.com/TeamNewPipe/NewPipeExtractor/issues/1287#issuecomment-2764573093, I suspect it originated from yt-dlp, as they use an almost identical one.
Closes: https://github.com/TeamNewPipe/NewPipeExtractor/issues/1287 Ref: https://github.com/TeamNewPipe/NewPipeExtractor/issues/1287#issuecomment-2764573093
- [x] I carefully read the contribution guidelines and agree to them.
- [ ] I have tested the API against NewPipe.
- [ ] I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.
At this point of time, I think, it makes sense to think about separating this "deobfuscation function name extraction" part of code (or even some more) into some form that could be easily updated without updating the app.
Hi @FineFindus thanks for working on this. Do you also plan to incorporate a fix for https://github.com/TeamNewPipe/NewPipeExtractor/issues/1289 in your fork?
Do you also plan to incorporate a fix for https://github.com/TeamNewPipe/NewPipeExtractor/issues/1289 in your fork?
Not unless there is a corresponding PR here, but I'm also not aware of any fix.
Not unless there is a corresponding PR here, but I'm also not aware of any fix.
yt-dlp has it working but it still needs to be ported to NewPipeExtractor
With the players I'm getting, this still finds the correct function, however the function structure itself has changed and now also relies on a global variable. Implemented support for it in https://github.com/TeamNewPipe/NewPipeExtractor/pull/1290/commits/60d3b71cb33ea867dee984d2d04637a53c285ee8.
Looks like the use allow case letters and single quotes now. Should now work again.