NewPipeExtractor icon indicating copy to clipboard operation
NewPipeExtractor copied to clipboard

Soundcloud comments extraction fails for some videos (“Page doesn't contain an URL”)

Open Profpatsch opened this issue 1 year ago • 1 comments

Checklist

  • [X] I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • [X] I am aware that this issue is being opened for the NewPipe Extractor, NOT the app, and my bug report will be dismissed otherwise.
  • [X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • [X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • [X] This issue contains only one bug.
  • [X] I have read and understood the contribution guidelines.

Affected version

9fb03f6c87ec0a919ffb56922c5bc6c6bebc6c46

Steps to reproduce the bug

Try to load the comments for e.g. https://soundcloud.com/user-722618400/a-real-playa

Expected behavior

Comments should be returned

Actual behavior

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: GB
  • Content Language: en-GB
  • App Language: en_GB
  • Service: none
  • Version: 0.27.2
  • OS: Linux Android 13 - 33
Crash log

java.lang.IllegalArgumentException: Page doesn't contain an URL
	at org.schabi.newpipe.extractor.services.soundcloud.extractors.SoundcloudCommentsExtractor.getPage(SoundcloudCommentsExtractor.java:44)
	at org.schabi.newpipe.extractor.comments.CommentsInfo.getMoreItems(CommentsInfo.java:79)
	at org.schabi.newpipe.paging.CommentsSource$load$info$1.invokeSuspend(CommentsSource.kt:23)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
	at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:113)
	at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:89)
	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:589)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:823)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:720)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:707)
	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [LazyStandaloneCoroutine{Cancelling}@16d25a5, Dispatchers.Main.immediate]


Originally posted by @Stypox in https://github.com/TeamNewPipe/NewPipe/issues/11060#issuecomment-2490595741

Screenshots/Screen recordings

No response

Logs

No response

Additional information

See https://github.com/TeamNewPipe/NewPipe/issues/11728

Profpatsch avatar Nov 21 '24 14:11 Profpatsch

From a very short debugging session, it looks like multiple pages of comments are loaded, and at one point the Page object contains a null URL (probably when there’s no more comments to load).

Profpatsch avatar Nov 21 '24 14:11 Profpatsch