NewPipeExtractor icon indicating copy to clipboard operation
NewPipeExtractor copied to clipboard

[MediaCCC] Allow obtaining channel tab link handler

Open Stypox opened this issue 1 year ago • 3 comments

  • [x] I carefully read the contribution guidelines and agree to them.
  • [x] I have tested the API against NewPipe.
  • [x] I agree to create a pull request for NewPipe: TeamNewPipe/NewPipe#10717

This is a proper fix for https://github.com/TeamNewPipe/NewPipe/issues/10698. Now it is possible to obtain a channel tab link handler, and null is never returned. The comments scattered around the code should explain my approach better than I could do in the PR description ;-), but the important point is that I reused the existing channel link handler for channel tabs, too.

Fixes TransactionTooLargeException when switching away from NewPipe while there are MediaCCC channels open. Before I could reproduce this consistently, while with this PR the crash is fixed.

The fact that the channel and the channel tab have the same url made it so that NewPipe would cache them both under the same key. I opened TeamNewPipe/NewPipe#10717 to fix that, and you can try the APK there to test these changes.

Stypox avatar Dec 30 '23 22:12 Stypox

I guess this is a fix for https://github.com/TeamNewPipe/NewPipe/issues/10714, isn't it?

TobiGr avatar Dec 31 '23 00:12 TobiGr

Probably it is, although the log posted by the user was fixed in your hotfix PR

Stypox avatar Dec 31 '23 08:12 Stypox

Ah, I just saw that the user listed 0.26.1 as affected version, but the logs indicate that the crash was happening on 0.26.0...

TobiGr avatar Dec 31 '23 10:12 TobiGr