TeamNewPipe
[PeerTube] Add support for PeerTube v6 features
- [x] I carefully read the contribution guidelines and agree to them.
- [x] I have tested the API against NewPipe.
- [x] I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.
Description
PeerTube 6.0.0 added support for multiple new features which are implemented in this PR:
- [x] support for stream segments/chapters extraction: implement
PeerTubeStreamExtractor.getStreamSegments() - [x] support for storyboard / video preview: implement
PeerTubeStreamExtractor.getFrames()
Videos for testing
- https://tube.tchncs.de/w/6U8A1AZ8nEkzgZXwf2kdW7
- https://framatube.org/w/vqABGP97fEjo7RhPuDnSZk
I don't think you need to do breaking changes. Can't you catch errors when getting thumbnails and chapters like done for description and throwing an ExtractionException wrapping the original one?
It always jumps to the beginning when I select a chapter cause the timestamp is 0:00.
@Profpatsch Please edit comments to add more info instead of making multiple consecutive comments.
@Profpatsch Thank you for the review! (I hope that we will be able to review your PRs soon)
Please edit comments to add more info instead of making multiple consecutive comments.
Usually there is a large number of comments on all NewPipe repos, many people get notified about comments and thus receive notifications about new comments. Some team members do community management and therefore check all the new comments on information which might be important for other team members to check out asap. However, if there is no or just little new info in a comment, they waste their time. For that reason we try to motivate people to edit their comments when they want to add minor details.
Neither of these features are working for me using the listed test videos on 0.27.0 RC1.
The RC uses @AudricV's yt-fix_comments_extraction branch which is 23 commits behind TeamNewPipe/NewPipeExtractor dev
Is there a reason it's not up to date? Bit weird to have people test an RC that doesn't have all the features we claim it does.
I guess the reason is that I didn't notice that yt-fix_comments_extraction (i.e. the unmerged #1163) was 23 commits behind dev, otherwise I would have rebased that PR on top of dev.
