NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Optimize svg assets

Open RiedleroD opened this issue 1 year ago • 3 comments

I wanted to finish optimizing all of them before opening the PR but I think that's not happening anymore. As far as I can see, none of those SVGs are actually directly used inside the app. Otherwise, this would probably be a significant performance improvement. So this PR really only saves about 60KiB when downloading the repo and not much else. Maybe next time someone wants to change some of those icons it'll be easier because they're less messy. idk.

I'll probably optimize some of the worse xml files that actually get used some other time and open another PR.

What is it?

  • [ ] Bugfix (user facing)
  • [ ] Feature (user facing)
  • [ ] Codebase improvement (dev facing)
  • [x] Meta improvement to the project (dev facing)

Description of the changes in your PR

  • optimized svg files in various ways

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

RiedleroD avatar Feb 12 '23 15:02 RiedleroD

The github preview shows that all optimized svgs now have a size of 0x0px, e.g.:

image

I feel like this might lead to problems if some code implicitly depends on these default height/widths?

Profpatsch avatar Mar 25 '24 13:03 Profpatsch

huh, will look into it in a month or so. Currently absolutely swamped with work from my thesis, diploma project & finals 😓

RiedleroD avatar Mar 27 '24 08:03 RiedleroD

Currently absolutely swamped with work from my thesis, diploma project & finals

Good luck with those! Ace them all!

opusforlife2 avatar Mar 28 '24 14:03 opusforlife2