NewPipe
NewPipe copied to clipboard
TeamNewPipe
Moved player notification setting to notification section
What is it?
- [x] Bugfix (user facing)
- [ ] Feature (user facing)
- [ ] Codebase improvement (dev facing)
- [ ] Meta improvement to the project (dev facing)
Description of the changes in your PR
Moved player notification setting to notification section
Before/After Screenshots/Screen Record
| Before | After |
|---|---|
|
https://user-images.githubusercontent.com/76740999/208883449-8ae038c2-409c-4939-a85d-31479dd6ee47.mp4 |
https://user-images.githubusercontent.com/76740999/208883465-53aa48a4-1fa9-4bd7-b0a8-451181d3a8cf.mp4 |
Fixes the following issue(s)
- Fixes #8232
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence
- [x] I read the contribution guidelines.
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
No Duplication information
![sonarcloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
You should put Player Notifications above New Stream Notifications instead. Because, these options are related to each other.
Settings will be redesigned by #10849, so we don't need to care about that here.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
See analysis details on SonarCloud