NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

download screen should be cancellable only by a dedicated button - not by touch outside

Open goyalyashpal opened this issue 1 year ago • 4 comments

Checklist

  • [X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • [X] I have read the FAQ and my problem isn't listed.
  • [X] I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • [X] I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • [X] This issue contains only one feature request.
  • [X] I have read and understood the contribution guidelines.

Feature description

Scenario:

  • While sharing a video link to newpipe, a dialog appears - showing the options.
  • On choosing download from that - the download dialog/popup opens but with some prominent delay, and meanwhile the control returns to normal android system

The problem:

  • the user gets busy in other app/activity while newpipe is still processing in the bg,
  • then the download ui of newpipe opens all of a sudden
  • and user while already performing some other action, clicks on an area outside the download dialog - which dismisses it, and here we go again

So:

  • the download ui can have a cancel button, and the current behaviour of touch outside to cancel/dismiss should be suppressed/removed

Why do you want this feature?

already shared in the "feature description" above - these two are mingled in this case

Additional information

alternate considered:

  • ignore this, this would be bad: ~~blocking the UI (say with a spinning circle - haha, classic android kitkat styled lol) to indicate that newpipe is processing the download request~~

goyalyashpal avatar Nov 06 '22 17:11 goyalyashpal

A simple toast would help a lot. "Please wait while the download dialog is loaded."

opusforlife2 avatar Nov 06 '22 17:11 opusforlife2

A simple toast would help a lot. "Please wait while the download dialog is loaded."

  • sorry, i forgot to remove the last point "there's no hint that anything related to newpipe is even happening" from the "(current) scenario" - that was not my main concern. [edit: 'have ~~striken it out~~ removed it]
  • the main concern is that the download dialog is dismissed on clicking outside - which happens too easily as the user is most likely interacting with some other application meanwhile

goyalyashpal avatar Nov 06 '22 17:11 goyalyashpal

@goyalyashpal ?

opusforlife2 avatar Feb 01 '24 18:02 opusforlife2

i guess there were lots of changes in the way downloading progress showed up. i thought it was fixed by some pr.

but retrying now, it wasnt. so, my mistake.

goyalyashpal avatar Feb 02 '24 02:02 goyalyashpal